Support complex64 tensor - real scalar operations (like numpy does) #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is always possible to operate on a Complex64 tensor with a real scalar without loss of precision, so we allow it without explicit type conversion. This is supported by numpy, and makes complex tensor arithmetic more convenient to use (by avoiding having to explicitly make many obvious conversions to complex). As an example, assuming `t` is a Tensor[Complex64], this let's you write expressions such as: ``` (complex(1.0 / sqrt(2.0)) *. t -. complex(1.0)) /. complex(t.size.float) ``` as follows: ``` ((1.0 / sqrt(2.0)) *. t -. 1.0) /. t.size ``` which is much more easier to understand while being equally safe.
|
Nice, I agree that's useful. I barely use complex numbers in my code, so I never much stumbled over it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is always possible to operate on a Complex64 tensor with a real scalar without loss of precision, so we allow it without explicit type conversion.
This is supported by numpy, and makes complex tensor arithmetic more convenient to use (by avoiding having to explicitly make many obvious conversions to complex).
As an example, assuming
tis a Tensor[Complex64], this let's you write expressions such as:as follows:
which is much easier to understand while being equally safe.